[Bug 744459] opensles: Allow setting stream type

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=744459

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #296757|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 296757:
 --> (https://bugzilla.gnome.org/review?bug=744459&attachment=296757)

::: sys/opensles/openslescommon.h
@@ +39,3 @@
+  GST_OPENSLES_RECORDING_PRESET_VOICE_COMMUNICATION =
+    SL_ANDROID_RECORDING_PRESET_VOICE_COMMUNICATION,
+} GstOpenSLESRecordingPreset;

Why do you define your own enum here that directly maps to the Android enum?
Either we should have our own enum with our own values and map that internally
(to ensure API compatibility), or just use the Android enum (assuming API
compatibility by them).

::: sys/opensles/openslessrc.c
@@ +69,3 @@
+
+GType
+gst_opensles_recording_preset_get_type (void)

This should probably be in openslescommon.c then

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.