[Bug 743346] When system time is increased the ongoing RTSP sessions will time out.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=743346

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #296268|none                        |needs-work
             status|                            |

--- Comment #12 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 296268:
 --> (https://bugzilla.gnome.org/review?bug=743346&attachment=296268)

I don't like that every use of the API now has to check which specific clock is
used, like rtsp-session-pool.c. And we still have to default to the realtime
clock, so by default every session created by the server still has this bug.

Not sure what to do about this. Wim?

::: gst/rtsp-server/rtsp-session.c
@@ +125,3 @@

+  g_object_class_install_property (gobject_class, PROP_CLOCKTYPE,
+      g_param_spec_enum ("clocktype", "clocktype",

clock-type as property name, "Clock Type" for the second parameter

@@ +145,3 @@
   g_mutex_init (&priv->last_access_lock);
   priv->timeout = DEFAULT_TIMEOUT;
+

The clock-type should be initialized here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.