[Bug 736655] basesink: preroll issue for some clips which audio is shorter than video

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=736655

--- Comment #112 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to kevin from comment #104)
> (In reply to Sebastian Dröge (slomo) from comment #99)
> > Review of attachment 295410 [details] [review] [review]:
> > 
> > ::: gst/playback/gststreamsynchronizer.c
> > @@ +909,3 @@
> >          if (stream->is_eos && !stream->eos_sent) {
> >            self->send_gap_event = TRUE;
> > +          stream->gap_duration = GST_CLOCK_TIME_NONE;
> > 
> > This should probably also be reset in PAUSED->READY (where the segment is
> > already reset currently).
> 
> Do you mean set value to stream->gap_duration? The stream->gap_duration only
> used when self->send_gap_event is TRUE. So need set value to
> stream->gap_duration when set TRUE to self->send_gap_event.
> Not accept currently:)

Yes, it has no real effect... but it would seem cleaner to me to reset that
variable at that point too :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.