[Bug 744572] flowcombiner regressions

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=744572

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thiagossantos at gmail.com

--- Comment #3 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
gstflowcombiner uses the value stored in the pad itself to compute the flow
combination. The GstPad's value is stored for information only (it is not read
anywhere in GstPad code atm).

I'd be in favor of adding API to gstflowcombiner and/or gstpad to update this
value when the elements wants the pad to explicitly have a flow return, like
the EOS case you pointed.

Something like
gst_flow_combiner_update_pad_flow() or gst_pad_set_last_flow_return().

Doing it through the gstflowcombiner makes it more uniform and could make
future changes easier.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.