[Bug 744308] decodebin: race between setting use-buffering and max-size-time

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Feb 19 15:07:06 PST 2015


Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
 Attachment #296898|none                        |reviewed
             status|                            |

--- Comment #5 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 296898:
 --> (https://bugzilla.gnome.org/review?bug=744308&attachment=296898)

Thanks for the patch. It looks good and should fix the issue. I have only one
small suggestion that could make the code clearer IMHO. How about having
decodebin_set_queue_size() and decodebin_set_queue_size_full(), the later would
have the extra 'use_buffering' parameter while the former keeps the same
parameters we have now, gets the "use-buffering" from the multiqueue and passes
it to the _full() version.

Also, please attach patches in git format-patch so that it keeps the commit
message when applied to other trees.

You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

More information about the gstreamer-bugs mailing list