[Bug 744806] audiodecoder: early call to drain() causes segment event to be sent before caps

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=744806

Jan Schmidt <thaytan at noraisin.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #297290|none                        |needs-work
             status|                            |

--- Comment #4 from Jan Schmidt <thaytan at noraisin.net> ---
Review of attachment 297290:
 --> (https://bugzilla.gnome.org/review?bug=744806&attachment=297290)

I think we should revert my patch and replace it with one that updates the
output segment before decoding buffers, but don't send events yet, keep the
push_pending_events() until just before the first buffer is output.

I'm worried this patch will lead to a case where we still get things wrong in
reverse playback and never send EOS.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.