[Bug 734617] videodecoder: Call the child class finish() function on stream changes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=734617

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #297571|none                        |accepted-commit_now
             status|                            |

--- Comment #15 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 297571:
 --> (https://bugzilla.gnome.org/review?bug=734617&attachment=297571)

Looks good to me

::: gst-libs/gst/video/gstvideodecoder.c
@@ +991,3 @@
+    } else {
+      if (decoder_class->drain)
+        ret = decoder_class->drain (dec);

Maybe this should be
if (drain) drain();
else { g_warning("implement drain!"); finish(); }

?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.