[Bug 744877] tools: bash completion for gst-inspect and gst-launch

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=744877

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #297682|none                        |reviewed
             status|                            |

--- Comment #11 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Review of attachment 297682:
 --> (https://bugzilla.gnome.org/review?bug=744877&attachment=297682)

Shouldn't the gst-completion-helper.c perhaps go into libs/gst/helpers/
instead? I don't think it belongs in data/

::: configure.ac
@@ -137,0 +137,6 @@
+dnl check for bash completion
+AC_ARG_WITH([bash-completion-dir],
+    AS_HELP_STRING([--with-bash-completion-dir[=PATH]],
... 3 more ...

--with-bash-completion-dir=PATH (and "install in this directory2) and then the
values are yes/no?

@@ -137,0 +137,12 @@
+dnl check for bash completion
+AC_ARG_WITH([bash-completion-dir],
+    AS_HELP_STRING([--with-bash-completion-dir[=PATH]],
... 9 more ...

I'm not sure this will always work if you use BASH_COMPLETION for a second
time, it might just skip it because it's got cached that it ran already.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.