[Bug 744922] osxaudiosrc: iOS resampling is stuttering

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=744922

Arun Raghavan <arun at accosted.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #297727|none                        |needs-work
             status|                            |

--- Comment #13 from Arun Raghavan <arun at accosted.net> ---
Review of attachment 297727:
 --> (https://bugzilla.gnome.org/review?bug=744922&attachment=297727)

Thanks for pinning this down.

::: sys/osxaudio/gstosxaudiosrc.c
@@ +404,3 @@

+  /* TODO: To support non-interleaved audio, go over all mBuffers,
+   *       not just the first one. */

Wouldn't the mDataByteSize be the same for all buffers (it'd be pretty weird to
get a different number of buffers for each channel).

::: sys/osxaudio/gstosxcoreaudiocommon.c
@@ +155,3 @@
   AudioBufferList *list;
+  gsize list_size;
+  UInt32 num_buffers, n;

Any reason to change this to UInt32? (and it'd be guint32, to be consistent and
glib-y)

@@ +170,3 @@
     list->mBuffers[n].mDataByteSize = size;
     list->mBuffers[n].mData = g_malloc (size);
+    if (list->mBuffers[n].mData == NULL) {

I'm pretty sure we don't actually deal with g_malloc() failing anywhere, and if
it did, the app would have a bigger catastrophe in its hands. The NULL check is
likely just going to be deadcode, in that case, and is better just skipped.

@@ +182,3 @@
 buffer_list_free (AudioBufferList * list)
 {
+  UInt32 n;

Again, any particular reason for changing the type?

@@ +186,2 @@
+  for (n = 0; n < list->mNumberBuffers; ++n) {
+    g_free (list->mBuffers[n].mData);

g_free() is a noop if the data is NULL.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.