[Bug 745042] utils: Add gst_bin_sync_children_states()

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Feb 25 05:53:40 PST 2015


Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
 Attachment #297701|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 297701:
 --> (https://bugzilla.gnome.org/review?bug=745042&attachment=297701)

::: gst/gstutils.c
@@ +3091,3 @@
+  gboolean success = TRUE;
+  it = gst_bin_iterate_elements (bin);

As discussed, this should use gst_bin_iterate_sorted(). Otherwise we might
change elements states in the wrong order: activate an upstream element, which
sends data to a deactivated downstream elements, then gets GST_FLOW_FLUSHING
and stops.

You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

More information about the gstreamer-bugs mailing list