[Bug 744783] gst-validate: support for non flushing seeks

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Feb 25 07:52:30 PST 2015


Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
 Attachment #297892|none                        |accepted-commit_now
             status|                            |

--- Comment #13 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 297892:
 --> (https://bugzilla.gnome.org/review?bug=744783&attachment=297892)

::: validate/gst/validate/gst-validate-scenario.c
@@ +600,3 @@
+  /* Flushing seeks will be deemed done when an ASYNC_DONE message gets
+     received on the bus. We don't get one for non flushing seeks though,
+     so we rely on a discontinuity on the buffers. */

We do not rely on discontunuity anymore :)

I wonder if we could not alway rely on segments actually, that might even
cleaner as we check the seqnum which guarantees us the segment is the resultant
of the seek.

You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

More information about the gstreamer-bugs mailing list