[Bug 738013] v4l2allocator: issue with import_userptr() in single-planar API when n_planes > 1

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Feb 25 11:35:42 PST 2015


Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
 Attachment #295289|accepted-commit_now         |committed
             status|                            |

--- Comment #19 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 295289:
 --> (https://bugzilla.gnome.org/review?bug=738013&attachment=295289)

commit 600027a1ee83ef595cc5598633812c15e6b30db2
Author: Aurélien Zanelli <aurelien.zanelli at parrot.com>
Date:   Mon Oct 6 17:30:06 2014 +0200

    v4l2bufferpool: fix import_userptr() in single-planar API when n_planes > 1

    In the V4L2 single-planar API, when format is semi-planar/planar,
    drivers expect the planes to be contiguous in memory.
    So this commit change the way we handle semi-planar/planar format
    (n_planes > 1) when we use the single-planar API (group->n_mem == 1).

    To check that planes are contiguous and have expected size, ie: no
    padding. We test the fact that plane 'i' start address + plane 'i'
    expected size equals to plane 'i + 1' start address. If not, we return
    in error.

    Math are done in bufferpool rather than in allocator because the
    former is aware of video info.


You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

More information about the gstreamer-bugs mailing list