[Bug 745197] pad: Don't fail latency query on unlinked pads

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Feb 25 23:59:25 PST 2015


Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
 Attachment #297949|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 297949:
 --> (https://bugzilla.gnome.org/review?bug=745197&attachment=297949)

Makes sense, also the same bug in a few other places. At least input-selector,
aggregator, adder, videomixer. Please go over all our code and grep for
gst_query_set_latency() :)

::: gst/gstpad.c
@@ +3102,3 @@
+    /* No peer, so let's return some default */
+    gst_query_set_latency (query, FALSE, 0, -1);
+    res = TRUE;

Just doing nothing here is enough. The two lines above have no effect as the
latency query "query" is just unreffed below, and res is never used again.

The only way how things failed before was that they went into the branch above
and caused g_value_set_boolean(ret, FALSE).

You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

More information about the gstreamer-bugs mailing list