[Bug 744246] gl: Broken VideoAlignment handling?

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=744246

Matthew Waters <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #297935|reviewed                    |rejected
             status|                            |

--- Comment #10 from Matthew Waters <ystreet00 at gmail.com> ---
Review of attachment 297935:
 --> (https://bugzilla.gnome.org/review?bug=744246&attachment=297935)

Seems to be missing the GL side of things.

::: gst-libs/gst/gl/gstglmemory.c
@@ -727,3 @@
   mem->notify = notify;
   mem->user_data = user_data;
-  mem->data_wrapped = FALSE;

Curious as to why you remove this line?

@@ +826,3 @@
     }

+    data = (guint8 *) gl_mem->data + gl_mem->mem.offset;

You seem to be missing this computation for the GL case.  i.e. the data
parameter to glTexSubImage2D inside _upload_memory and glReadPixels for
_download_memory.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.