[Bug 744246] gl: Broken VideoAlignment handling?

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=744246

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW

--- Comment #12 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
(In reply to Matthew Waters from comment #10)
> Review of attachment 297935 [details] [review]:
> 
> Seems to be missing the GL side of things.
> 
> ::: gst-libs/gst/gl/gstglmemory.c
> @@ -727,3 @@
>    mem->notify = notify;
>    mem->user_data = user_data;
> -  mem->data_wrapped = FALSE;
> 
> Curious as to why you remove this line?

We now have an allocated data pointer, and a data pointer. Remembering if the
data pointer was allocated of not is no longer needed.

> 
> @@ +826,3 @@
>      }
>  
> +    data = (guint8 *) gl_mem->data + gl_mem->mem.offset;
> 
> You seem to be missing this computation for the GL case.  i.e. the data
> parameter to glTexSubImage2D inside _upload_memory and glReadPixels for
> _download_memory.

Ok, I'll check.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.