[Bug 744090] mpegtsmux doesn't permit to add stream during play

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=744090

--- Comment #14 from Andreas Schuler <andreas at schulerdev.de> ---
Okay, first of all, there must went anything wrong. I used git format-patch.
Looks like I uploaded the wrong file....sorry.

::: gst/mpegtsmux/mpegtsmux.c
@@ +748,3 @@
+            if (!ret)
+            {
+                GST_ELEMENT_ERROR (mux, STREAM, MUX, ("Reading program map
failed. Assuming default"), (NULL));


Hmm....I copied it from the old functions. But it's a good time to think about
this part of code. In my opinion, when the developer adds a program map, he
want to generate more than one program. If this doesn't works, all video and
audio streams are added to one program. Normally this stream is not usable as
intendet and we should stop with a error because the user doesn't suppose to
get a stream like this. 

But when we do this, maybee we don't need the following line in code:
idx = DEFAULT_PROG_ID;


@@ +1263,2 @@
   {
+      GST_ELEMENT_ERROR (mux, STREAM, MUX, ("Can't init stream on pad %"
GST_PTR_FORMAT , COLLECT_DATA_PAD (best)), (NULL));

Hmm...yes, the old message is better.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.