[Bug 742367] wavparse: initialize variables

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Jan 5 04:11:35 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=742367
  GStreamer | gst-plugins-good | unspecified

Luis de Bethencourt <luis> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |luis at debethencourt.com

--- Comment #2 from Luis de Bethencourt <luis at debethencourt.com> 2015-01-05 12:11:29 UTC ---
You are correct about that if variable event is False, variables cur and stop
aren't set by gst_event_parse_seek(). But, event being False also means line
421:

    if (!event || wav->state != GST_WAVPARSE_DATA) {

Will resolve to True and the true statement block will be run. Meanwhile the
lines you are worried about (437 and 441) are in the false statement block of
that conditional.

There is no combination of values where cur and stop are used without being
initialized.

At least I don't see any situation where this might be a problem. If you know
of any please say so :) If not I will close this bug.

Thanks for looking into this.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list