[Bug 741751] mssdemux: use correct type for setting bitrate

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Jan 6 01:23:07 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=741751
  GStreamer | gst-plugins-bad | 1.4.5

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |t.i.m at zen.co.uk
     Ever Confirmed|0                           |1
           Severity|normal                      |critical

--- Comment #6 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2015-01-06 09:23:02 UTC ---
This issue looks valid. We're passing 64-bit as vararg argument, but only
specify G_TYPE_INT, which means on platforms where sizeof(int) != 64 we're not
reading enough bits off the stack and then everything goes wrong from there.

Question is whether the fix should be:

  ..., "bitrate", G_TYPE_INT, (int) q->bitrate, ...

or (as proposed)

  ..., "bitrate", G_TYPE_INT64, q->bitrate, ...

Depends on who reads this later I suppose.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list