[Bug 741751] mssdemux: pass correct type through vararg function to avoid potential crash

Wed Jan 7 02:23:16 PST 2015

https://bugzilla.gnome.org/show_bug.cgi?id=741751
  GStreamer | gst-plugins-bad | 1.4.5

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.5.1
            Summary|mssdemux: use correct type  |mssdemux: pass correct type
                   |for setting bitrate         |through vararg function to
                   |                            |avoid potential crash

--- Comment #12 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2015-01-07 10:23:12 UTC ---
Thanks for the bug report and the patch. Pushed to master:

commit de246c6741d70077a06ea223297c5ebc57ba471c
Author: Rajat Verma <rajat.verma at st.com>
Date:   Wed Jan 7 11:31:30 2015 +0530

    mssdemux: fix crash while setting bitrate in caps structure

    q->bitrate is a guint64, but G_TYPE_INT may read fewer bits
    off the stack, and if we pass more then the NULL sentinel
    may not be found at the right place, which in turn might
    lead to crashes.

    https://bugzilla.gnome.org/show_bug.cgi?id=741751

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.