[Bug 742074] v4l2videodec: leaks filedescriptors

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Jan 8 21:00:14 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=742074
  GStreamer | gst-plugins-good | git

Nicolas Dufresne (stormer) <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2015-01-09 05:00:08 UTC ---
Just went with a completly different approach, it concist of reverting back to
old behaviour of not keeping a ref on queued buffer. Instead, we just don't
hand it over to the free list until dequeued.

commit e47a5708f007753a0ef46757b6b547dfb1f6f174
Author: Nicolas Dufresne <nicolas.dufresne at collabora.co.uk>
Date:   Wed Jan 7 17:55:14 2015 -0500

    v4l2bufferpool: Don't clean buffer array in dispose

    This should already have been done, plus this code is incorrect
    and may lead to crash.

    https://bugzilla.gnome.org/show_bug.cgi?id=742074

commit bbcfd594e487cf2036644741600f0963fa4e8228
Author: Nicolas Dufresne <nicolas.dufresne at collabora.co.uk>
Date:   Wed Jan 7 17:48:31 2015 -0500

    v4l2bufferpool: Don't ref queued output buffer

    This partly revert to the old 1.2 behavior. Instead of keeping a
    reference to the output buffer queued, we simply release them but
    don't forward it to GstBufferPool. This way, the buffer pool don't
    need to be flushed to be stopped.

    https://bugzilla.gnome.org/show_bug.cgi?id=742074

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list