[Bug 741260] gstpluginfeature: Properly expose the class.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741260
  GStreamer | gstreamer (core) | git

--- Comment #6 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2015-01-09 20:50:49 UTC ---
Review of attachment 292334:
 --> (https://bugzilla.gnome.org/review?bug=741260&attachment=292334)

+1 for the idea. I think having api for this also simplifies the internal code
(e.g. the weak pointer).

::: gst/gstpluginfeature.c
@@ +197,3 @@
+ * @feature: feature to set plugin on
+ * @plugin: Set the plugin that provides this feature
+ *

missing doc line.

@@ +204,3 @@
+  g_return_if_fail (feature != NULL);
+  g_return_if_fail (GST_IS_PLUGIN_FEATURE (feature));
+ * @plugin: Set the plugin that provides this feature

wouldn't you need to g_object_remove_weak_pointer () if feature->priv->plugin
!= NULL

@@ +210,3 @@
+    feature->priv->plugin_name = plugin->desc.name;
+  } else {
+void

do we need this?

::: gst/gstregistry.c
@@ +752,3 @@
+
+  rank1 = gst_plugin_feature_get_rank (GST_PLUGIN_FEATURE (fac1));
+  rank2 = gst_plugin_feature_get_rank (GST_PLUGIN_FEATURE (fac2));

nit:
guint rank1 = gst_plugin_feature_get_rank (GST_PLUGIN_FEATURE (fac1));
guint rank2 = gst_plugin_feature_get_rank (GST_PLUGIN_FEATURE (fac2));

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.