[Bug 611689] [NEW PLUGIN] crossfeed plugin
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Sat Jan 10 14:18:17 PST 2015
https://bugzilla.gnome.org/show_bug.cgi?id=611689
GStreamer | gst-plugins-bad | git
Stefan Sauer (gstreamer, gtkdoc dev) <ensonic> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #294246|none |reviewed
status| |
--- Comment #19 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2015-01-10 22:18:12 UTC ---
Review of attachment 294246:
--> (https://bugzilla.gnome.org/review?bug=611689&attachment=294246)
Looks good now.
::: ext/bs2b/gstbs2b.c
@@ +157,3 @@
+ GST_BS2B_DP_LOCK (element);
+ element->bs2bdp = bs2b_open ();
+ GST_BS2B_DP_UNLOCK (element);
You should not need the lock/unlock here.
@@ +255,3 @@
+ bs2b_close (element->bs2bdp);
+ element->bs2bdp = NULL;
+ GST_BS2B_DP_UNLOCK (element);
You should not need the lock in finalize.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list