[Bug 732908] audioresample: skips samples unless input buffers have correct size
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Wed Jan 14 00:47:27 PST 2015
https://bugzilla.gnome.org/show_bug.cgi?id=732908
GStreamer | gst-plugins-base | unspecified
--- Comment #14 from Jan Alexander Steffens (heftig) <jan.steffens at gmail.com> 2015-01-14 08:47:25 UTC ---
Created an attachment (id=294495)
View: https://bugzilla.gnome.org/attachment.cgi?id=294495
Review: https://bugzilla.gnome.org/review?bug=732908&attachment=294495
proposed patch
How about this?
audioresample: Try to prevent endless looping
Speex may decide not to consume any samples because it can't write any. I've
seen a hang during draining caused by the resample loop never terminating. In
that case, resampling happened as normal until olen was 0 but ilen was still 1.
_process_native then reduced ichunk to 0, so ilen never decreased below 1 and
the loop never terminated.
Instead of reverting 684cf44 ({audioresample: don't skip input samples), break
only if all output samples have been produced and speex refuses to consume any
more input samples.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list