[Bug 742917] v4l2: Allow scaling in the v4l2*convert element
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Wed Jan 14 06:28:23 PST 2015
https://bugzilla.gnome.org/show_bug.cgi?id=742917
GStreamer | gst-plugins-good | unspecified
--- Comment #2 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2015-01-14 14:28:22 UTC ---
Thanks Enrico for this patch, I'll have a look as soon as possible. Meanwhile,
I have few general question:
Is this negotiation code inspired from videoscale element ?
Have you taken pixel aspect ratio into account ?
Do you support device that cannot scale ?
Finally, just mentioning, I had a discussion with Hans and could not conclude
if my use of the CROP ioctl was right or not. Ideally we'd be using SELECTION
but it was not implemented when I did that work. Have you made some tests with
various cropping ?
I also notice that you forgot to update the Klass field of this element. The
software videoscaler sets:
Klass Filter/Converter/Video/Scaler
These will eventually be used for auto-plugging elements in the future.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list