[Bug 742973] validate: launcher: Fix log file creation when redirecting to stdout

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=742973
  GStreamer | gst-devtools | git

Thibault Saunier <tsaunier> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #294599|none                        |reviewed
             status|                            |

--- Comment #3 from Thibault Saunier <tsaunier at gnome.org> 2015-01-15 14:50:49 UTC ---
Review of attachment 294599:
 --> (https://bugzilla.gnome.org/review?bug=742973&attachment=294599)

Looks generally good, just a few simple comments.

::: validate/launcher/baseclasses.py
@@ +349,3 @@
     def clean(self, full=True):
         Test.clean(self, full=full)
+        if hasattr(self, 'validatelogs') and not self.options.redirect_logs:

You should make sure the attribute is set instead of checking of the attribute
exists.

::: validate/launcher/main.py
@@ +251,3 @@
         if not os.path.exists(self.dest):
             os.makedirs(self.dest)
+        if not os.path.exists(self.logsdir):

Where was it done before?

@@ +408,3 @@
                            help="Directory where to store logs and rendered
files. Default is MAIN_DIR")
     dir_group.add_argument("-l", "--logs-dir", dest="logsdir",
+                           help="Directory where to store logs, default is
OUTPUT_DIR/logs.")

I agree it is better to have a dedicated parametter but I think we should still
accept -l stdout/stderr here, so we keep the same user interface, removing it
from the doc is still good.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.