[Bug 731404] hlsdemux memmory leak

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=731404
  GStreamer | gst-plugins-bad | 1.4.0

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #294695|none                        |reviewed
             status|                            |

--- Comment #17 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2015-01-16 15:43:10 UTC ---
Review of attachment 294695:
 --> (https://bugzilla.gnome.org/review?bug=731404&attachment=294695)

::: gst/playback/gstdecodebin2.c
@@ +3443,3 @@
+
+static void
+gst_decode_chain_start_free_hidden_groups_thead (GstDecodeChain * chain)

Typo: thead

@@ +3465,3 @@
+  GST_DEBUG_OBJECT (chain->dbin, "Started free-hidden-groups thread");
+  /* We do not need to wait for it or get any results from it */
+  g_thread_unref (thread);

Is the unreffing necessary here really? I remember that the refcounting with
GThread was a bit weird, or maybe not?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.