[Bug 738302] videorate: Should increase minimum buffer in allocation query

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738302
  GStreamer | gst-plugins-base | git master

--- Comment #18 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2015-01-18 20:12:23 UTC ---
Review of attachment 294811:
 --> (https://bugzilla.gnome.org/review?bug=738302&attachment=294811)

I think I'm correctly using the base class now. This time instead of bumping
max, I drop that allocation. I save the maximum seen minimum. There is a risk
of over-allocating though with that, but I don't think we can do anything about
it. Basically the min contains the provider minimum and the minimum of other
elements in between. The provider minimum might no longer be relevant if it's
pool isn't being used.

At least, this would be the case if the one where to use v4l2sink or
v4l2transform (encoder in the future) with (output-)io-mode=mmap/dmabuf. As the
element would be copying into it's own pool, this extra allocation would be
needed. At the same time it would be relevant in USERPTR or DMABUF-import
io-mode. I think it would be fixed in v4l2 propose allocation by lowering the
absolute maximum and adding the remaining at gst_buffer_pool_set_config().

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.