[Bug 743178] pulsesink: Free format_info in query_getcaps

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=743178
  GStreamer | gst-plugins-good | 1.4.5

Thiago Sousa Santos <thiagossantos> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #294873|none                        |needs-work
             status|                            |

--- Comment #2 from Thiago Sousa Santos <thiagossantos at gmail.com> 2015-01-19 13:55:45 UTC ---
Review of attachment 294873:
 --> (https://bugzilla.gnome.org/review?bug=743178&attachment=294873)

Nice find, just one remark on the code.

Also, when submitting a new version please check previous gstreamer commit
messages and follow the same style. Something like:


pulseseink: [title of the commit]

[description - multiple lines if needed]

[bug url]

::: ext/pulse/pulsesink.c
@@ +2170,1 @@
       goto unlock;

The code right after this also frees this object so it would be better to have
the free happening before the if as it needs to be done for both branches.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.