[Bug 732908] audioresample: skips samples unless input buffers have correct size
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Mon Jan 19 10:36:51 PST 2015
https://bugzilla.gnome.org/show_bug.cgi?id=732908
GStreamer | gst-plugins-base | unspecified
Sebastian Dröge (slomo) <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #17 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2015-01-19 18:36:46 UTC ---
Thanks for testing! :)
commit a636c39638e7d667d71ec5a1070c3e468cf45a73
Author: Jan Alexander Steffens (heftig) <jsteffens at make.tv>
Date: Tue Jan 13 16:07:06 2015 +0100
audioresample: Try to prevent endless looping
Speex may decide not to consume any samples because it can't write any.
I've
seen a hang during draining caused by the resample loop never terminating.
In that case, resampling happened as normal until olen was 0 but ilen was
still 1. _process_native then reduced ichunk to 0, so ilen never decreased
below 1 and the loop never terminated.
Instead of reverting 684cf44 ({audioresample: don't skip input samples),
break only if all output samples have been produced and speex refuses
to consume any more input samples.
https://bugzilla.gnome.org/show_bug.cgi?id=732908
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list