[Bug 736655] basesink: preroll issue for some clips which audio is shorter than video

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=736655
  GStreamer | gstreamer (core) | 1.2.3

--- Comment #70 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2015-01-20 14:44:57 UTC ---
(In reply to comment #65)

> > Access to GAP duration should probably be protected by the mutex too
> 
> Those code is in gst_stream_synchronizer_wait(). gst_stream_synchronizer_wait()
> is called in below code. gst_stream_synchronizer_wait() should be called with
> GST_STREAM_SYNCHRONIZER_LOCK.
> 
> +          GST_STREAM_SYNCHRONIZER_LOCK (self);
> +          self->send_gap_event = TRUE;
> +          ret = gst_stream_synchronizer_wait (self, srcpad);
> +          GST_STREAM_SYNCHRONIZER_UNLOCK (self);

But that means that you send the GAP event while holding that mutex. That's
never a good idea :) Don't send any events, queries or buffers downstream while
holding the mutex.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.