[Bug 740196] [PATCH] baseparse: Add vfunc to adjust output segment
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Wed Jan 21 05:35:16 PST 2015
https://bugzilla.gnome.org/show_bug.cgi?id=740196
GStreamer | gstreamer (core) | git master
--- Comment #2 from Carlos Rafael Giani <dv at pseudoterminal.org> 2015-01-21 13:35:14 UTC ---
With LAME, I have the following checks in mpegaudioparse:
/* if there is no LAME tag information, there is nothing to do */
if ((mp3parse->encoder_delay == 0) && (mp3parse->encoder_padding == 0))
return;
/* only adjust segments which are open ended */
if ((segment->start != 0) || (segment->stop != -1))
return;
/* only adjust TIME segments */
if (segment->format != GST_FORMAT_TIME)
return;
You are right that modifying any other segment type is not what you want in
that case. I am not sure that limiting the adjust_segment function to open
ended segments is wise though. Are there other use cases where you _do_ want to
modify a segment that is in the middle of the stream for example?
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list