[Bug 738319] rtpsession: fix Early Feedback Transmission

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738319
  GStreamer | gst-plugins-good | 1.4.1

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2015-01-22 09:56:07 UTC ---
If I'm not mistaken we currently *always* do immediate feedback. AFAIU
immediate feedback means that it's always allowed to send up to one early RTCP
packet before the next scheduled one, while in early feedback mode this might
not be allowed every now and then (rules not 100% clear to me).

See the definition of allow_early in the RFC (allowing up to one early RTCP
packet), the definitions of early RTCP packet, early rtcp mode and immediate
feedback mode (1.1) and 3.3 a) vs b).

However this is also a bit weird still, as 3.3a) talks about reporting each
event immediately. Which would not be true with my understanding (you can
report one event immediately, then you have to wait until the next regular RTCP
packet).
I would've expected immediate RTCP mode to mean that it is possible to send
multiple early packets between the regular RTCP packets, but nothing in the RFC
seems to support this view.


So if my understanding is correct, we would have the throttle sending of early
packets if we're above the FB threshold. I don't see that in the RFC but it
would be the implication, and I would guess that it would mean to only send an
early packet every group_size/threshold packets.


Does someone have any additional insights?


FWIW, I also have some other fixes related to this. Attaching now.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.