[Bug 743311] mpeg2dec does not cope if downstream buffer allocation has stride != width

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Jan 22 09:52:57 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=743311
  GStreamer | gst-plugins-ugly | git master

Nicolas Dufresne (stormer) <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #295201|none                        |needs-work
             status|                            |

--- Comment #9 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2015-01-22 17:52:56 UTC ---
Review of attachment 295201:
 --> (https://bugzilla.gnome.org/review?bug=743311&attachment=295201)

::: ext/mpeg2dec/gstmpeg2dec.c
@@ +352,3 @@
   gst_video_codec_state_unref (state);

+  return chroma_stride_acceptable;

Nearly there. Failing here would mean failing the pipeline. To reject a pool,
what one usually do is to update the allocation with same size/min/max but pool
set to NULL. And finally return true. The base class will crate a generic video
pool for you.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list