[Bug 738319] rtpsession: fix Early Feedback Transmission

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738319
  GStreamer | gst-plugins-good | 1.4.1

--- Comment #17 from Olivier Crête <olivier.crete at ocrete.ca> 2015-01-22 20:27:21 UTC ---
Review of attachment 295153:
 --> (https://bugzilla.gnome.org/review?bug=738319&attachment=295153)

::: gst/rtpmanager/rtpsession.c
@@ +3108,3 @@
   gst_rtcp_packet_fb_set_media_ssrc (packet, 0);

+  /* FIXME: RFC 4585 3.5.2 5) Check retained packets if we duplicate one here?
*/

This is trivial to implement, we should probably just do it,

@@ +3179,3 @@
     return;

+  /* FIXME: RFC 4585 3.5.2 5) Check retained packets if we duplicate one here?
*/

This one is non-trivial, as we probably want to suppress packets that only
describe NACKs that have already been sent even if the RTCP packet is not
identical. For example, if "1 2 5" is received, the first nack would be "3 4",
but if 4 is later received, a nack with just "3" should probably be suppressed
even though it's not identical. Or maybe I'm over-thinking this.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.