[Bug 742684] audiomixer: Un-even locking in GstAggregator causes the tests to fail

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=742684
  GStreamer | gst-plugins-bad | git master

Thibault Saunier <tsaunier> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #295223|none                        |reviewed
             status|                            |

--- Comment #29 from Thibault Saunier <tsaunier at gnome.org> 2015-01-23 14:50:07 UTC ---
Review of attachment 295223:
 --> (https://bugzilla.gnome.org/review?bug=742684&attachment=295223)

I really do not think it is a good idea to use GST_OBJECT_LOCK here, moreover
we have a cond associated with that lock and I can very well imagine deadlock
happening because of that approach.

Also, I do not see any reason why you would hide GST_OBJECT_LOCK in a new macro
instead of using it directly?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.