[Bug 743414] New: rtpvp8: undefined behaviour. division by zero

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Jan 23 08:50:42 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=743414
  GStreamer | gst-plugins-good | git master

           Summary: rtpvp8: undefined behaviour. division by zero
    Classification: Platform
           Product: GStreamer
           Version: git master
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: luis at debethencourt.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=295288)
 View: https://bugzilla.gnome.org/attachment.cgi?id=295288
 Review: https://bugzilla.gnome.org/review?bug=743414&attachment=295288

proposed patch

gst_rtp_buffer_calc_payload_len () can return zero if packet length is smaller
than header length. It is unlikely but this function checks for this and
returns 0, then if it does, max_paylen will become zero and will be the divisor
in the next line.

  list = gst_buffer_list_new_sized ((size / max_paylen) + 1);

Which would make _handle_buffer() of rtpvp8 have undefined behaviour.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list