[Bug 738013] v4l2allocator: issue with import_userptr() in single-planar API when n_planes > 1

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Jan 23 09:04:07 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=738013
  GStreamer | gst-plugins-good | git master

Nicolas Dufresne (stormer) <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #295286|none                        |reviewed
             status|                            |

--- Comment #13 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2015-01-23 17:04:03 UTC ---
Review of attachment 295286:
 --> (https://bugzilla.gnome.org/review?bug=738013&attachment=295286)

This look good, nice work.

::: sys/v4l2/gstv4l2bufferpool.c
@@ +220,3 @@
   if (finfo && (finfo->format != GST_VIDEO_FORMAT_UNKNOWN &&
           finfo->format != GST_VIDEO_FORMAT_ENCODED)) {
+    gsize size[GST_VIDEO_MAX_COMPONENTS] = { 0, };

It's the same right now, and we assume all over the place that they are in same
order, but let's use GST_VIDEO_MAX_PLANES here.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list