[Bug 670156] tags: id3v2 POPM support
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Mon Jan 26 01:54:14 PST 2015
https://bugzilla.gnome.org/show_bug.cgi?id=670156
GStreamer | gst-plugins-base | unspecified
--- Comment #11 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2015-01-26 09:54:08 UTC ---
(In reply to comment #10)
> (In reply to comment #9)
> > First patch would be to introduce a new tag in
> > http://cgit.freedesktop.org/gstreamer/gstreamer/tree/gst/gsttaglist.h
> > http://cgit.freedesktop.org/gstreamer/gstreamer/tree/gst/gsttaglist.c
>
> Isn't this what the following lines are already doing?
Indeed this s good.
>
> >/**
> > * GST_TAG_USER_RATING:
> > *
> > * Rating attributed by a person (likely the application user).
> > * The higher the value, the more the user likes this media
> > * (unsigned int from 0 to 100)
> > */
> >#define GST_TAG_USER_RATING "user-rating"
>
> I would like to try and work on this feature, could you point me in the right
> direction?
A quick grep though the sources shows that right now only XMP implements this:
./gst-plugins-base/gst-libs/gst/tag/gstxmptag.c:968
You would need to update the source for id3demux to handle the POPM rating and
map it to a GST_TAG_USER_RATING. Next step would be to also patch
id3v2mux/id3mux to also write the tag.
When you have it working (or like to get a revewiew) please attach git format
patches here.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list