[Bug 727483] v4l2sink: Keep aspect ratio when device scale

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727483
  GStreamer | gst-plugins-good | unspecified

--- Comment #11 from Aurélien Zanelli <aurelien.zanelli at parrot.com> 2015-01-26 10:15:08 UTC ---
(In reply to comment #10)
> Review of attachment 285272 [details]:
> 
> Just checking, do we keep aspect ratio by default with that path ?
Yes unless we can't keep the DAR at all. Which is bad since we have a property
to say if we want to keep aspect or not: 'force-aspect-ratio'. :)
Maybe, before doing anything, we should check it.

> 
> ::: sys/v4l2/gstv4l2sink.c
> @@ +586,3 @@
>    /* TODO: videosink width/height should be scaled according to
>     * pixel-aspect-ratio
>     */
> 
> Can't this comment be removed now ? If not why ?

At the moment I wrote the patch, I think I didn't know what to do with it. And
since i let v4l2sink video_width and video_height, which are unscaled value, i
let the comment. But according to it, I should have set the scaled value.

By the way, what is the purpose of videosink width and height attributes ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.