[Bug 735666] design doc : trick mode handling in demuxers (SKIP)
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Mon Jan 26 06:17:19 PST 2015
https://bugzilla.gnome.org/show_bug.cgi?id=735666
GStreamer | gstreamer (core) | unspecified
Tim-Philipp Müller <t.i.m> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #295448|none |reviewed
status| |
--- Comment #17 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2015-01-26 14:17:13 UTC ---
(From update of attachment 295448)
Looks good to me. One issue though: the define ensures backwards-compatibility
for our C API, but I don't think it ensure the same for our g-i / python API.
Not that I know why anyone would be using a flag that's not implemented yet,
but perhaps we should keep it as part of the enum and set it to the same value.
+1 for the FLAG_TRICKMODE* naming instead of FLAG_SKIP_, it makes things more
discoverable for users IMHO and the names are less confusing then (e.g.
SKIP_KEY_UNIT_ONLY - sounds like it means it should only decode delta frames).
Please add a "(Since 1.6)" at the end of the @NEWFLAG: ... gtk-doc line.
Otherwise good to push IMO.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list