[Bug 743511] singledecodebin: A convenience element to decode a single stream
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Mon Jan 26 07:20:37 PST 2015
https://bugzilla.gnome.org/show_bug.cgi?id=743511
GStreamer | gst-plugins-bad | unspecified
Sebastian Dröge (slomo) <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #295421|none |needs-work
status| |
--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2015-01-26 15:20:35 UTC ---
Review of attachment 295421:
--> (https://bugzilla.gnome.org/review?bug=743511&attachment=295421)
You should also add this to the documentation build if you already added some
docs :)
::: gst/singledecodebin/gstsingledecodebin.c
@@ +56,3 @@
+ GstPad *srcpad;
+ GstSingleDecodeBin *sdbin =
+ GST_SINGLE_DECODE_BIN (gst_element_get_parent (dbin));
You're leaking sdbin here
@@ +58,3 @@
+ GST_SINGLE_DECODE_BIN (gst_element_get_parent (dbin));
+
+ if (sdbin->connected) {
pad-added can be emitted from different threads at the same time
@@ +63,3 @@
+ }
+
+ srcpad = gst_element_get_static_pad (GST_ELEMENT (sdbin), "src");
Maybe only do this here if a) downstream accepts the caps of the pad (or no
downstream is there), and b) the caps of the pad intersect with a newly added
caps property of singledecodebin.
That would allow you to make linking this a bit more flexible, e.g. "... !
singledecodebin ! pulsesink" would also work if the first pad added by
decodebin is a video pad.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list