[Bug 743629] validate: add an extra test suite for checking elements

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=743629
  GStreamer | gst-devtools | unspecified

Thibault Saunier <tsaunier> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #295628|none                        |reviewed
             status|                            |

--- Comment #3 from Thibault Saunier <tsaunier at gnome.org> 2015-01-28 12:56:43 UTC ---
Review of attachment 295628:
 --> (https://bugzilla.gnome.org/review?bug=743629&attachment=295628)

You should not use a fakesink by default but check if you are muted or not and
use autovideosink if it is not case (also by default
GstValidatePipelineTestGenerator uses %(videosink)s and %(audiosink)s to handle
that for you).

::: validate/launcher/apps/gstvalidate.py
@@ +25,3 @@
 from launcher.loggable import Loggable
+from gi.repository import Gst
+from gi.repository import GObject

I think we do not want to depend on GObject Introspection here

@@ +209,1 @@
+class
GstValidateCheckAllElementTestsGenerator(GstValidatePipelineTestsGenerator):

You should just move that to the testsuite implementation instead of here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.