[Bug 740891] opusenc: Propose to rename "audio" property to "voice"

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740891
  GStreamer | gst-plugins-bad | git master

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #295680|none                        |reviewed
             status|                            |

--- Comment #7 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2015-01-28 17:19:58 UTC ---
(From update of attachment 295680)
>+    {OPUS_APPLICATION_AUDIO, "Generic audio", "generic"},
>+    {OPUS_APPLICATION_VOIP, "Voice", "voip"},

Let's not use "voip" please, it should be "voice" also in this case. Although
Speech/speech is perhaps better, I don't know.

>-  g_object_class_install_property (gobject_class, PROP_AUDIO,
>-      g_param_spec_boolean ("audio", "Audio or voice",
>-          "Audio or voice", DEFAULT_AUDIO,
>-          G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
>+  g_object_class_install_property (gobject_class, PROP_AUDIO_TYPE,
>+      g_param_spec_enum ("audio-type", "What type of audio to optimize for",
>+          "What type of audio to optimize for", GST_OPUS_ENC_TYPE_AUDIO_TYPE,
>+          DEFAULT_AUDIO_TYPE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));

Let's deprecate the old name, that will make GLib throw warnings, then remove
it in 1.7 after the 1.6 release so people have some time to update their code.

Otherwise good to go in imho.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.