[Bug 742684] aggregator: Locking logic should be reviewed, cleaned up, and documented

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=742684
  GStreamer | gst-plugins-bad | git master

--- Comment #63 from Thibault Saunier <tsaunier at gnome.org> 2015-01-29 10:05:38 UTC ---
Not closing as we still need to document the locking order and in case we still
have things
to discuss but I think locking is looking much better now.


Attachment 295222 pushed as 0a2dc11 - aggregator: Protect data with the same
mutex as GCond
Attachment 295223 pushed as cc3f418 - aggregator: Replace event lock with pad's
object lock
Attachment 295224 pushed as 68ac643 - aggregator: Protect exported pad members
with the pad's object lock
Attachment 295225 pushed as ee04b09 - videoaggregator: Lock access to members
of GstAggregatorPad
Attachment 295226 pushed as 067b44e - audiomixer: Don't reset caps on flush
Attachment 295227 pushed as cc605f4 - aggregator: Consistently lock some
members
Attachment 295228 pushed as a2f1aa3 - audiomixer: Clear GstAudioInfo the the
caps
Attachment 295229 pushed as eddd5fd - aggregator: Consistenly lock the
flow_return state
Attachment 295231 pushed as 94e2d78 - audiomixer: Avoid race in caps
negotiation
Attachment 295232 pushed as 4a5882e - aggregator: Protect the tags with the
object lock
Attachment 295233 pushed as f7070dc - aggregator: Protect the srcpad caps
negotiation with the stream lock
Attachment 295234 pushed as 41d2667 - aggregator: Document locking for
gst_aggregator_get_latency_unlocked()
Attachment 295235 pushed as 9df8ac0 - aggregator: Protect all latency related
members with the object lock
Attachment 295236 pushed as ea76d39 - aggregator: Document how the segment is
protected
Attachment 295237 pushed as 93d0b51 - aggregator: Document locking of
GstAggregatorPrivate members
Attachment 295238 pushed as f98e457 - audiomixer: Replace racy timeout based
tested with drain query
Attachment 295245 pushed as fb6ba27 - audiomixer: Make flush start/stop test
non-racy
Attachment 295428 pushed as 1a07467 - aggregator: Make the PAD_LOCK private
Attachment 295429 pushed as ccf329d - aggregator: More fixes around locking
when accessing protected private fields
Attachment 295458 pushed as d8eef43 - aggregator: Hide GstAggregatorPad buffer
and EOS fileds
Attachment 295467 pushed as 71e4c48 - aggregator: Cleanup locking around
AggregatorPad flush related fields

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.