[Bug 740891] opusenc: Propose to rename "audio" property to "voice"

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740891
  GStreamer | gst-plugins-bad | git master

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #295733|none                        |needs-work
             status|                            |

--- Comment #9 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2015-01-29 11:06:06 UTC ---
(From update of attachment 295733)
>+    {OPUS_APPLICATION_VOIP, "Speech", "speech"},

Fwiw, I don't mind if it's voice or speech, I just didn't like the Voice/voip
mismatch. (Arguably voice is the more generic term :))


>-      g_param_spec_boolean ("audio", "Audio or voice",
>-          "Audio or voice", DEFAULT_AUDIO,
>+      g_param_spec_boolean ("audio",
>+          "Audio or voice (obsolete, use audio-type)",
>+          "Audio or voice (obsolete, use audio-type)", DEFAULT_AUDIO,
>           G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));

 | G_PARAM_DEPRECATED

so that GLib generates warnings for us if the old property is used.

Please push then. Thanks!

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.