[Bug 741030] theoradec: Sets video-meta width/height from padded values

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741030
  GStreamer | gst-plugins-good | git master

--- Comment #10 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2015-01-31 23:14:14 UTC ---
(In reply to comment #9)
> There are only a few cases where a transform could work on the entire padded
> surface safely, really. You can't even do colourspace transforms on them unless
> you can guarantee there'll be not subpixel blending from undefined padding
> pixels outside the cropped area.

Well, in the scenario you are using a crop, it is expected that the full padded
image is sub-sampled aligned. The crop portion may not be though. If the crop
area is what is sub-sample aligned, then you should be using VideoAlignment
like libav is doing. Note that this is hypothetical, just like libav, theora
alignment respect the subsampling, so both full image and sub-image are in fact
aligned.

> 
> Perhaps it would be better to add new fields to GstVideoMeta to provide the
> entire uncropped size, or a new GstVideoBufferMeta (GstVideoMapMeta?) with a
> separate GstVideoInfo

The width and hight in VideoMeta is alread a duplicate from caps (hence use
less if cropped). So I prefer Sebastion suggestion on comment 4. Which makes
this size useful.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.