[Bug 751823] glimagesink: possible null pointer dereference

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751823

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
                 CC|                            |t.i.m at zen.co.uk

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
I see where you're coming from here (I'm guessing some static analyzer
complained that you're dereferencing error unconditionally and later check if
it's non-NULL), but I don't think this should be fixed like that.

If a function returns a GError on failure, it should always do that. And
_create_context() always does that as far as I can tell. So the right thing to
do would be to drop the if (error) check here, or to use g_clear_error()
instead (which may or may not make the static analyzer shut up).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.