[Bug 751883] rtcpbuffer: Fix validation of packets with padding

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751883

Stian Selnes (stianse) <stian.selnes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #306687|needs-work                  |none
             status|                            |
 Attachment #306687|0                           |1
        is obsolete|                            |

--- Comment #2 from Stian Selnes (stianse) <stian.selnes at gmail.com> ---
Created attachment 306786
  --> https://bugzilla.gnome.org/attachment.cgi?id=306786&action=edit
Patch with fix and tests

Changed previous patch according to code review and also changed the
wrong_padding check.

The commit message includes a description of what the value of the so called
pad byte should be. It's not the length of the packet as the previous code
assumed, but it's the number of padded bytes at the end of the packet
(including itself). I also changed the check for a valid pad byte value to be
more in line what is explicitly stated in the RFC. It must be a multiple of 4,
and the value 0 cannot be allowed since the count includes the pad byte itself.
(Previous patch only check the upper and lower limit that made sense, but I
realize that was a bit confusing).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.