[Bug 751778] metainfo: some meta has no transform_func in plugins

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751778

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #306972|none                        |needs-work
             status|                            |

--- Comment #18 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 306972:
 --> (https://bugzilla.gnome.org/review?bug=751778&attachment=306972)

::: gst-libs/gst/audio/gstaudiometa.c
@@ +64,3 @@
   smeta = (GstAudioDownmixMeta *) meta;
+
+  dmeta = gst_buffer_add_audio_downmix_meta (dest, smeta->from_position,

Not your fault, but this transform function seems wrong. It should only copy
the meta if the transform type is COPY.

E.g. if this goes through audioconvert and changes channel numbers, then it
shouldn't just be copied probably.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.