[Bug 751540] gltestsrc: implement missing patterns, port to GL3 / ES3, load shaders with GIO
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Tue Jul 7 06:06:47 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=751540
Matthew Waters <ystreet00 at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #306166|none |needs-work
status| |
--- Comment #12 from Matthew Waters <ystreet00 at gmail.com> ---
Review of attachment 306166:
--> (https://bugzilla.gnome.org/review?bug=751540&attachment=306166)
Port the shader to GLES2 and don't upload unchanging index data every frame.
::: ext/gl/gltestsrc.c
@@ +447,3 @@
+ w, h,
+ w, 0,
+ 0, 0,
Are you sure that these should be 0->width/height? 0->width/height might mean
we're overdrawing outside the framebuffer dimensions.
::: ext/gl/gstgltestsrc.c
@@ -320,3 @@
void main() \
{ \
- vec2 xy_index= floor((gl_FragCoord.xy-vec2(0.5,0.5))/checker_width); \
To remove the gl_FragCoord one has to pass the dimensions of the framebuffer
into the shader.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list